fixup! topology2: Use SAMPLE_TYPE_MSB_INTEGER for ALH copier #8800
Conversation
bardliao
force-pushed
the
fixup-alh-dai-SAMPLE_TYPE_MSB_INTEGER
branch
from
ccc24f9 to
45548c5
Compare
Some ALH DAI copier missed SAMPLE_TYPE_MSB_INTEGER setting. Signed-off-by: Bard Liao <[email protected]>
| @@ -461,6 +463,8 @@ IncludeByKey.SDW_AMP_FEEDBACK { | |||
| out_valid_bit_depth 32 | |||
| out_ch_cfg $CHANNEL_CONFIG_3_POINT_1 | |||
| out_ch_map $CHANNEL_MAP_3_POINT_1 | |||
| out_sample_type $SAMPLE_TYPE_MSB_INTEGER | |||
| out_fmt_cfg "$[($out_channels | ($out_valid_bit_depth * 256))]" | |||
There was a problem hiding this comment.
This should have no practical impact given out_valid_bit_depth is 32. The bit-alignment only takes effect when valid-bits is smaller than the container size.
There was a problem hiding this comment.
This should have no practical impact given out_valid_bit_depth is 32. The bit-alignment only takes effect when valid-bits is smaller than the container size.
Right, but it is better to be consistent. Other ALH dais set SAMPLE_TYPE_MSB_INTEGER no matter the valid_bit_depth is 32 bit or not. :)
@lgirdwood Sorry, I didn't get your comment. The PR is a fixup of 2541e55 that is a commit of #8359. The request is that we should set SAMPLE_TYPE_MSB_INTEGER for 24 bit ALH DAIs. It is no impact if we set it for 16 or 32 bit format because the valid bits and the container bits are the same in the cases. However, we set SAMPLE_TYPE_MSB_INTEGER for all ALH DAIs for consistent. PR #7959 may explain more. |
Some ALH DAI copier missed SAMPLE_TYPE_MSB_INTEGER setting.